Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error handling #11

Closed
jmartin-sul opened this issue Aug 6, 2019 · 2 comments
Closed

add error handling #11

jmartin-sul opened this issue Aug 6, 2019 · 2 comments

Comments

@jmartin-sul
Copy link
Collaborator

jmartin-sul commented Aug 6, 2019

e.g. for network timeouts, etc.

a few things i can think of are:

  • some sort of error message to both the console and the complete.log output file.
  • make sure that an error retrieving an individual resource doesn't cause the whole export attempt to fail
    • but make it clear that there was not full success and that some resources may be missing from the export.

spawned by #1

@jmartin-sul jmartin-sul mentioned this issue Aug 6, 2019
@justinlittman
Copy link
Contributor

@jmartin-sul suggests that this is closable.

@jmartin-sul
Copy link
Collaborator Author

jmartin-sul commented Nov 6, 2019

a little elaboration:

some sort of error message to both the console and the complete.log output file.

console logging (and honeybadger logging) are now both in place. so we should be informed about errors when they occur, including timeouts and the sort of mis-handling described in #49.

make sure that an error retrieving an individual resource doesn't cause the whole export attempt to fail

there is now more robust error handling than when this ticket was filed, and some catch statements have been added that should address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants