From cb65c8dc36d60186a3340c7094b1197c9ae70271 Mon Sep 17 00:00:00 2001 From: "St. Elmo" Date: Mon, 7 Jun 2021 09:50:37 +0200 Subject: [PATCH 1/2] update contribution guidelines to include the use of emojis --- .github/CONTRIBUTING.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 08f669615..67bc49cb4 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -167,9 +167,10 @@ submitting the pull requests. 1. **Make a fork of the repository**, commit the modifications in a **separate branch** and push the branch to your fork. 2. Make a pull request where you describe the motivation and expected outcome - for the users. Specifically, consider any possible incompatibilities, and - the necessity to increment the version number after your changes are - applied. + for the users. Specifically, consider any possible incompatibilities, and the + necessity to increment the version number after your changes are applied. + Label your pull request with a [semantic emoji](https://gitmoji.dev/) to + indicate what it addresses. 3. After submitting the pull request, verify that all status checks (tests, documentation) are passing. Make sure any new contribution is properly documented and tested (you may want to check with coverage tools, using From 4cfa2013893ff013534b01baa64c440142e8987f Mon Sep 17 00:00:00 2001 From: "St. Elmo" Date: Mon, 7 Jun 2021 09:53:45 +0200 Subject: [PATCH 2/2] even more specific where the emoji goes --- .github/CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 67bc49cb4..ecd3a6c9f 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -169,8 +169,8 @@ submitting the pull requests. 2. Make a pull request where you describe the motivation and expected outcome for the users. Specifically, consider any possible incompatibilities, and the necessity to increment the version number after your changes are applied. - Label your pull request with a [semantic emoji](https://gitmoji.dev/) to - indicate what it addresses. + Label your pull request with a [semantic emoji](https://gitmoji.dev/) in the + title to indicate what it addresses. 3. After submitting the pull request, verify that all status checks (tests, documentation) are passing. Make sure any new contribution is properly documented and tested (you may want to check with coverage tools, using