Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the cause of test failures with OSQP / MOMA #485

Closed
exaexa opened this issue Nov 2, 2021 · 1 comment · Fixed by #486
Closed

Check the cause of test failures with OSQP / MOMA #485

exaexa opened this issue Nov 2, 2021 · 1 comment · Fixed by #486
Assignees
Labels
quality improves maintainability and code clarity

Comments

@exaexa
Copy link
Collaborator

exaexa commented Nov 2, 2021

The problem here:
https://gitlab.lcsb.uni.lu/lcsb-biocore/COBREXA.jl/-/jobs/309330

MOMA: Test Failed at /builds/lcsb-biocore/COBREXA.jl/test/analysis/minimize_metabolic_adjustment.jl:13
  Expression: isapprox(moma["BIOMASS_Ecoli_core_w_GAM"], 0.06214149238730545, atol = TEST_TOLERANCE)
   Evaluated: isapprox(0.05885376722059405, 0.06214149238730545; atol = 9.999999999999999e-6)
Stacktrace:
 [1] macro expansion
   @ /builds/lcsb-biocore/COBREXA.jl/test/analysis/minimize_metabolic_adjustment.jl:13 [inlined]
 [2] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
 [3] top-level scope
   @ /builds/lcsb-biocore/COBREXA.jl/test/analysis/minimize_metabolic_adjustment.jl:2
[ Info: analysis/minimize_metabolic_adjustment.jl done in 12.43s

...was kinda quickfixed in PR #484 by simply increasing the test tolerance. A better explanation of what actually happened is needed.

Likely the freedom in the model just allows the results to come from a relatively big range, at that point we wouldn't need to care a lot but it would be better checked by at least 1 other person. :D

@exaexa exaexa added the quality improves maintainability and code clarity label Nov 2, 2021
@stelmo stelmo linked a pull request Nov 2, 2021 that will close this issue
@exaexa
Copy link
Collaborator Author

exaexa commented Nov 2, 2021

Closed by #486

@exaexa exaexa closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants