You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For adjusting the models, there should be 3 variants of functions that allow the users to make variants.
Let's assume verb such as "add" and object" such as reaction, the combined function would be called add_reactionoradd_reactions`.
We should have:
verb_object and verb_objects with parameters (model, object_description) that returns a modified copy of the model, leaving the stuff in model intact
verb_object! and verb_object! with the same parameters that modify the model in-place
mod_verb_object with parameters (object_description) that returns a function that behaves like verb_object, for usage in screen().
This should be consistent across all modifications (where sensible). Plural names are preferred where it makes sense, singular ones should be a simple wrappers.
Naming of the 3rd kind of the modifications functions is to be discussed, some possible good choices include:
For adjusting the models, there should be 3 variants of functions that allow the users to make variants.
Let's assume
verb
such as "add" andobject" such as reaction, the combined function would be called
add_reactionor
add_reactions`.We should have:
verb_object
andverb_objects
with parameters(model, object_description)
that returns a modified copy of themodel
, leaving the stuff inmodel
intactverb_object!
andverb_object!
with the same parameters that modify themodel
in-placemod_verb_object
with parameters(object_description)
that returns a function that behaves likeverb_object
, for usage inscreen()
.This should be consistent across all modifications (where sensible). Plural names are preferred where it makes sense, singular ones should be a simple wrappers.
Naming of the 3rd kind of the modifications functions is to be discussed, some possible good choices include:
mod_add_reaction
with_added_reaction
added_reaction
with_reaction
(requires verb change though)Cc @stelmo @laurentheirendt
The text was updated successfully, but these errors were encountered: