Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve UI/UX on Three-Way Merge Editor #214

Open
LennartCode opened this issue Jun 19, 2024 · 1 comment
Open

[FEATURE] Improve UI/UX on Three-Way Merge Editor #214

LennartCode opened this issue Jun 19, 2024 · 1 comment
Labels
feature New feature or request

Comments

@LennartCode
Copy link

LennartCode commented Jun 19, 2024

Currently the three-way merge editor is not very user friendly. Especially people with no git experience might have serious trouble understanding it.

Here are some suggestions:

  • Actually do three-way merging using a base file, for example from Syncthing's history (similarly described here) instead of a two way merge with displayed output
  • Add an option to either display the result as rendered markdown or plain text
  • Correctly render the resulting markdown (for example relevant for frontmatter) or detect the problem, choose plain text and display an explanation (See [BUG] Markdown is not rendered correctly in Preview Merged File #215)
  • Open the merge editor directly instead of the Difference View when selecting view conflict
  • Provide buttons to navigate to the next conflict in a footer or header
  • Hide the meta data behind a button, menu or such. In most cases everything but the file name is irrelevant to the user
  • In the three-way merge editor provide buttons to accept either of the files completely
  • Use cherry-picking for constructing the merged file, similarly to what VSCode does but label the files left and right or after the devices instead of incoming and current as the user does not need to have a concept of incoming changes to successfully merge and this might increase confusion

These suggestions are rather opinionated and mostly stand on their own. I would like to inspire changes and am happy to discuss them!

@LBF38
Copy link
Owner

LBF38 commented Jun 19, 2024

Thank you for your feedback ! I'll include them in future versions when I've got time.
Feel free to contribute to the project if you want too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

No branches or pull requests

2 participants