Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DepoFluxWriter exception could be more clear. #43

Open
brettviren opened this issue Jan 17, 2024 · 0 comments
Open

DepoFluxWriter exception could be more clear. #43

brettviren opened this issue Jan 17, 2024 · 0 comments

Comments

@brettviren
Copy link
Member

As part of the "collusion" (see https://github.com/LArSoft/larwirecell/blob/develop/larwirecell/docs/depofluxwriter.org#track-ids ) the same art::Event "label" must be used for the vector of SimEnergyDeposit by both SimDepoSetSource and DepoFluxWriter. If the user gets this wrong by naming two different but existing labels then DepoFluxWriter will throw an exception about an out-of-bounds access which is somewhat cryptic.

Better would be to have DepoFluxWriter explicitly check the size of the SED vector against the vector of depos from WCT and raise an exception with a more explicit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant