Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module-specific report filters are ignored in merged project report #622

Closed
tonykolomeytsev opened this issue Jun 4, 2024 · 3 comments
Closed
Assignees
Labels
Question Support request issue type S: in progress Status: implementing or design in process

Comments

@tonykolomeytsev
Copy link

tonykolomeytsev commented Jun 4, 2024

Hello! I use kover in multimodule android project for generating reports for single modules and for the whole project (aggregated project report). The project contains both Android and JVM submodules.

When I run :koverHtmlReport, I get the aggregated HTML report with only filtering rules from root build.gradle. But specific rules from the subprojects' build.gradle are ignored. Is it expected behavior?

Kover 0.8.0

@tonykolomeytsev tonykolomeytsev added Question Support request issue type S: untriaged Status: issue reported but unprocessed labels Jun 4, 2024
@tonykolomeytsev tonykolomeytsev changed the title Module-specific report filters are ignored in aggregated project report Module-specific report filters are ignored in merged project report Jun 5, 2024
@shanshin
Copy link
Collaborator

shanshin commented Jun 5, 2024

Yes, this is the expected behavior.

The block kover { reports { ... } } configures only those Kover tasks that are located in the same module in which this config is specified.

So, if you specify filters in the root project, then these filters will affect only the result of the :koverHtmlReport task, if you specify filters in subproject child, then of the :child:koverHtmlReport task, etc.

If you are using the root project to aggregate coverage reports (create a merged report), then you need to configure the block kover { reports { ... } } only in the root project.

@shanshin shanshin added S: in progress Status: implementing or design in process and removed S: untriaged Status: issue reported but unprocessed labels Jun 5, 2024
@tonykolomeytsev
Copy link
Author

Okay. Anyway thanks for the quick response. I will try to implement desired behavior myself

@shanshin
Copy link
Collaborator

shanshin commented Jun 5, 2024

Closed as answered.
Feel free to create new issue if you have any additional questions.

@shanshin shanshin closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Support request issue type S: in progress Status: implementing or design in process
Projects
None yet
Development

No branches or pull requests

2 participants