Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS: On Windows, use Win32 API accepting wide string to avoid issues with the file path encoding #388

Open
fzhinkin opened this issue Sep 9, 2024 · 0 comments
Open

FS: On Windows, use Win32 API accepting wide string to avoid issues with the file path encoding #388

fzhinkin opened this issue Sep 9, 2024 · 0 comments
Labels
bug encodings fs integration An issue related to the integration with other libraries or platform-specific APIs

Comments

@fzhinkin
Copy link
Collaborator

fzhinkin commented Sep 9, 2024

As it was pointed in #241 (comment), there might be issues with file paths on systems using something other than Unicode was a default encoding (for instance, it could be GB2312 on Windows with Chinese localization).

To avoid such issues, Native implementation should use Win32 calls that accepts wide strings (i.e. UTF-16 strings).
@fzhinkin fzhinkin added bug encodings fs integration An issue related to the integration with other libraries or platform-specific APIs labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug encodings fs integration An issue related to the integration with other libraries or platform-specific APIs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fzhinkin