Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing main entry point convention #158

Closed
dzharkov opened this issue Sep 18, 2018 · 9 comments
Closed

Enhancing main entry point convention #158

dzharkov opened this issue Sep 18, 2018 · 9 comments

Comments

@dzharkov
Copy link
Contributor

Proposal: https://github.com/Kotlin/KEEP/blob/enhancing-main-convention/proposals/enhancing-main-convention.md

PR for comments: #157

@Dico200
Copy link

Dico200 commented Sep 18, 2018

from runSuspend definition for JVM:

override fun resumeWith(result: Result<Unit>) = synchronized(this) {

If there isn't a typealias for Result to SuccessOrFailure somewhere, I'm convinced the type should be SuccessOrFailure<Unit>.

@dzharkov
Copy link
Contributor Author

@Dico200 In 1.3 (since RC) it will be renamed to Result

@hannomalie
Copy link

@dzharkov Wow, that's a step! Is there any info about this step somewhere!? I'm just interested in the topic after I followed the discussion about the naming of SuccessOrFailure/Result.

@elizarov
Copy link
Contributor

elizarov commented Sep 19, 2018

@hannespernpeintner

Wow, that's a step! Is there any info about this step somewhere!? I'm just interested in the topic after I followed the discussion about the naming of SuccessOrFailure/Result.

Please watch updates in the corresponding KEEP. It will be updated: #127

@gildor
Copy link
Contributor

gildor commented Sep 19, 2018

If there are problems with suspend implementation on Kotlin Native, maybe we could support at least part of new convention: omit args from main function

@Dico200
Copy link

Dico200 commented Sep 19, 2018

@dzharkov
I read all the discussion in KEEP #127 just days ago, checked back there now and I don't see any updates, nor in the file. I do not see anything conclusively saying that the decision was revisited.

So as far as I understand it, it's a change you intend to make - which has yet to be mentioned in the KEEP.
Which is fair enough, I just wanted to point out I don't recall such a decision being made.

@dzharkov
Copy link
Contributor Author

@gildor

If there are problems with suspend implementation on Kotlin Native, maybe we could support at least part of new convention: omit args from main function

I think at some point they will be supported

@dzharkov
Copy link
Contributor Author

@dzharkov
I read all the discussion in KEEP #127 just days ago, checked back there now and I don't see any updates, nor in the file. I do not see anything conclusively saying that the decision was revisited.

So as far as I understand it, it's a change you intend to make - which has yet to be mentioned in the KEEP.
Which is fair enough, I just wanted to point out I don't recall such a decision being made.

Finally, it's here
#127 (comment)

@dzharkov
Copy link
Contributor Author

Implemented in 1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants