fix(entity-consumers): optimize consumer data fetching in <AddConsumerModal /> and <AddToGroupModal />
#935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekolab
force-pushed
the
fix/add-consumer-modal-fetch
branch
from
170f22c to
eebe605
Compare
nekolab
requested review from
a team,
adamdehaven,
ValeryG and
jillztom
as code owners
…erModal />` Previously, `<AddConsumerModal />` and `<AddToGroupModal />` triggers `loadItems` during `onBeforeMount`, leading to premature and unnecessary data fetching, especially in scenarios where only browsing the list is required. This fetching strategy also resulted in outdated, non-refreshable data. To resolve this, `loadItems` has been shifted to a `watch` block, ensuring timely and relevant data fetching. Additionally, the sandbox page now references `VITE_KONG_MANAGER_CONSUMER_GROUP_ID` for dynamic consumer group ID handling, replacing the previously hardcoded value.
nekolab
force-pushed
the
fix/add-consumer-modal-fetch
branch
from
eebe605 to
51606c3
Compare
sumimakito
approved these changes
Nov 22, 2023
nekolab
changed the title
<AddConsumerModal /><AddConsumerModal /> and <AddToGroupModal />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
<AddConsumerModal />and<AddToGroupModal />triggersloadItemsduringonBeforeMount, leading to premature and unnecessary data fetching, especially in scenarios where only browsing the list is required.This fetching strategy also resulted in outdated, non-refreshable data. To resolve this,
loadItemshas been shifted to awatchblock, ensuring timely and relevant data fetching.Additionally, the sandbox page now references
VITE_KONG_MANAGER_CONSUMER_GROUP_IDfor dynamic consumer group ID handling, replacing the previously hardcoded value.Summary
PR Checklist