Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): add pagination for consumers/<id>/consumer_groups and consumer_groups/<id>/consumers #759

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat(*): add pagination for consumers/<id>/consumer_groups and consumer_groups/<id>/consumers #759

merged 1 commit into from
Dec 28, 2023

Conversation

raoxiaoyan
Copy link
Contributor

@raoxiaoyan raoxiaoyan commented Sep 6, 2023 •
edited by Leopoldthecoder
Loading

Summary

Adding pagination support for consumers/<id>/consumer_groups and consumer_groups/<id>/consumers endpoints.

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@raoxiaoyan raoxiaoyan requested review from a team as code owners September 6, 2023 09:18
@raoxiaoyan raoxiaoyan force-pushed the feat/FTI-5362 branch 3 times, most recently from 9664e57 to ec02147 Compare September 8, 2023 02:20
@Leopoldthecoder Leopoldthecoder self-assigned this Sep 8, 2023
@Leopoldthecoder Leopoldthecoder marked this pull request as draft September 8, 2023 08:21
@Leopoldthecoder Leopoldthecoder force-pushed the feat/FTI-5362 branch 2 times, most recently from 35650ed to 51f3750 Compare September 13, 2023 06:56
@Leopoldthecoder Leopoldthecoder force-pushed the feat/FTI-5362 branch 7 times, most recently from 6c20567 to 67e5ce8 Compare December 28, 2023 07:02
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review December 28, 2023 07:26
sumimakito
sumimakito approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and worked fine with Kong Manager

@Leopoldthecoder Leopoldthecoder merged commit efdb2fd into main Dec 28, 2023
8 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/FTI-5362 branch December 28, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito approved these changes

Assignees

@Leopoldthecoder Leopoldthecoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raoxiaoyan @sumimakito @Leopoldthecoder