feat(entities): add resizable + show hide columns for all GM entity tables [KHCP-11568] #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ager entity tables [KHCP-11568]
mptap
changed the title
mptap
force-pushed
the
feat/khcp-11568-add-resizable-show-hide-columns-entities-khcp-11568
branch
from
b77ec45 to
107be2d
Compare
kaiarrowood
reviewed
May 1, 2024
packages/entities/entities-shared/src/components/entity-base-table/EntityBaseTable.vue
Outdated
Show resolved
Hide resolved
kaiarrowood
reviewed
May 1, 2024
packages/entities/entities-shared/src/components/entity-base-table/EntityBaseTable.vue
Show resolved
Hide resolved
kaiarrowood
previously requested changes
May 1, 2024
…mns-entities-khcp-11568
mptap
force-pushed
the
feat/khcp-11568-add-resizable-show-hide-columns-entities-khcp-11568
branch
4 times, most recently
from
4acac6f to
3c69384
Compare
…bles, orgs, users
mptap
force-pushed
the
feat/khcp-11568-add-resizable-show-hide-columns-entities-khcp-11568
branch
from
3c69384 to
88d1269
Compare
kaiarrowood
reviewed
May 9, 2024
packages/entities/entities-shared/src/components/entity-base-table/EntityBaseTable.vue
Outdated
Show resolved
Hide resolved
kaiarrowood
previously approved these changes
May 9, 2024
There was a problem hiding this comment.
Code and functional looks good. Only a couple non-blocking suggestions. Nice work @mptap 🚀
mptap
deleted the
feat/khcp-11568-add-resizable-show-hide-columns-entities-khcp-11568
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/KHCP-11568
Consumed in https://github.com/Kong/konnect-ui-apps/pull/3090
Deploy Preview https://pr-3090--gateway-manager.cloud-preview.konghq.tech/gateway-manager