feat(*): reuse preprocessing form fields for config forms and save [khcp-10152] #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mptap
force-pushed
the
feat/preprocess-entity-form-fields-khcp-10152
branch
2 times, most recently
from
f87d53b to
6e37c69
Compare
jillztom
reviewed
Jan 15, 2024
jillztom
reviewed
Jan 15, 2024
packages/entities/entities-plugins/src/components/PluginForm.vue
Outdated
Show resolved
Hide resolved
jillztom
reviewed
Jan 15, 2024
packages/entities/entities-shared/src/components/common/JsonCodeBlock.vue
Outdated
Show resolved
Hide resolved
jillztom
reviewed
Jan 15, 2024
packages/entities/entities-shared/src/components/common/YamlCodeBlock.vue
Outdated
Show resolved
Hide resolved
|
Looks good in general. Added some minor/nit comments |
mptap
force-pushed
the
feat/preprocess-entity-form-fields-khcp-10152
branch
from
a26a892 to
4aeffb1
Compare
kaiarrowood
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/KHCP-10152
Extracted preprocessing form fields logic in reusable helpers, for use in both JSON/YAML config forms and form submission