feat(#3097): propagate translation failures for netv1.Ingress #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
changed the title
32 tasks
rainest
suggested changes
Nov 8, 2022
There was a problem hiding this comment.
Ditto the other review about not testing upstream. https://github.com/kubernetes/kubernetes/blob/c61c3fc492424bfcfabf132650c2bc4404ef2727/pkg/apis/networking/validation/validation.go#L442 and https://github.com/kubernetes/kubernetes/blob/c61c3fc492424bfcfabf132650c2bc4404ef2727/pkg/apis/networking/validation/validation.go#L49 are the relevant bits here.
Other than the minor test gripe, LGTM.
rainest
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It introduces propagating of translation failures related to Ingress resources:
Apart from that, it also removes validation of
//in the HTTP route path - it's already handled by the Kubernetes API itself - proved in the added integration test.Which issue this PR fixes:
Part of #3097.
Notes to reviewers:
I had to add strict causing object validations to the
NewTranslationFailureconstructor to make sure we won't reference empty/nil objects. I encountered such an issue withParentfield being empty for akongstate.Servicegenerated fromIngressin some cases (fixed in this PR).PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR