Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3097): add TranslationFailure and TranslationFailuresCollector with unit tests #3110

Merged
merged 8 commits into from
Oct 27, 2022

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Oct 27, 2022

What this PR does / why we need it:

Introduces utility types that are going to be used for collecting failures that happen during the translation process.

Which issue this PR fixes:
Part of #3097.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo requested a review from a team as a code owner October 27, 2022 11:55
@czeslavo czeslavo self-assigned this Oct 27, 2022
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 11:55 Inactive
@czeslavo czeslavo added the area/feature New feature or request label Oct 27, 2022
@czeslavo czeslavo changed the title Add TranslationError and TranslationErrorsCollector with unit tests feat(#3097): Add TranslationError and TranslationErrorsCollector with unit tests Oct 27, 2022
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 12:13 Inactive
@czeslavo czeslavo requested a review from jrsmroz October 27, 2022 12:20
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 12:38 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 12:38 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 12:43 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 12:51 Inactive
@czeslavo czeslavo requested a review from jrsmroz October 27, 2022 12:52
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 12:56 Inactive
@czeslavo czeslavo changed the title feat(#3097): Add TranslationError and TranslationErrorsCollector with unit tests feat(#3097): Add TranslationFailure and TranslationFailuresCollector with unit tests Oct 27, 2022
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 13:20 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 13:20 Inactive
@czeslavo czeslavo requested a review from pmalek October 27, 2022 14:08
jrsmroz
jrsmroz previously approved these changes Oct 27, 2022
pmalek
pmalek previously approved these changes Oct 27, 2022
@czeslavo czeslavo changed the title feat(#3097): Add TranslationFailure and TranslationFailuresCollector with unit tests feat(#3097): add TranslationFailure and TranslationFailuresCollector with unit tests Oct 27, 2022
@czeslavo czeslavo enabled auto-merge (squash) October 27, 2022 14:25
@czeslavo czeslavo dismissed stale reviews from pmalek and jrsmroz via 7e7e842 October 27, 2022 14:40
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 14:40 Inactive
@czeslavo czeslavo requested review from pmalek and jrsmroz October 27, 2022 14:41
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 15:03 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 15:03 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 15:04 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 15:04 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci October 27, 2022 15:10 Inactive
@czeslavo czeslavo merged commit 318e60f into main Oct 27, 2022
@czeslavo czeslavo deleted the feat/collecting-translation-errors branch October 27, 2022 15:10
czeslavo added a commit that referenced this pull request Oct 27, 2022
…with unit tests (#3110)

Introduces utility types that are going to be used for collecting failures that happen during the translation process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants