Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface deck errors as Kubernetes events #3492

Closed
1 of 2 tasks
czeslavo opened this issue Feb 6, 2023 · 2 comments · Fixed by #5785
Closed
1 of 2 tasks

Surface deck errors as Kubernetes events #3492

czeslavo opened this issue Feb 6, 2023 · 2 comments · Fixed by #5785
Labels
area/feature New feature or request

Comments

@czeslavo
Copy link
Contributor

czeslavo commented Feb 6, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Similarly to #3205, we'd like to make sure that all error/warnings detected by deck when applying configuration in DB-mode are properly propagated by means of Kubernetes events.

Proposed Solution

Refactor deck sync.Solver so it returns errors/warnings it detected.

Additional information

No response

Acceptance Criteria

  • When deck rejects an entity a Kubernetes Event is created on the resource that is the reason for rejection.
@mheap
Copy link
Member

mheap commented May 5, 2023

This is a nice to have, but given our primary topologies of DB-less and non-KIC with Konnect I think this should wait

@mflendrich
Copy link
Contributor

It may make sense to do #5289 as a prerequisite for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants