-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump Gateway API's Gateway from v1alpha2 to v1beta1 #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
added
the
area/gateway-api
Relating to upstream Kubernetes SIG Networking Gateway API
label
Sep 6, 2022
pmalek
force-pushed
the
replace-gateway-v1alpha2-with-gateway-v1beta1
branch
from
September 6, 2022 15:11
3119bf4
to
aa2ad2a
Compare
pmalek
force-pushed
the
replace-gateway-v1alpha2-with-gateway-v1beta1
branch
from
September 6, 2022 15:13
aa2ad2a
to
2685449
Compare
pmalek
force-pushed
the
replace-gateway-v1alpha2-with-gateway-v1beta1
branch
from
September 6, 2022 16:13
2685449
to
49f1345
Compare
pmalek
force-pushed
the
replace-gateway-v1alpha2-with-gateway-v1beta1
branch
from
September 6, 2022 18:10
49f1345
to
55700af
Compare
shaneutt
previously approved these changes
Sep 6, 2022
From CI:
|
pmalek
force-pushed
the
replace-gateway-v1alpha2-with-gateway-v1beta1
branch
from
September 6, 2022 19:51
55700af
to
19e1de5
Compare
Would seem we need another update to lock the k8s version in our CI:
|
pmalek
force-pushed
the
replace-gateway-v1alpha2-with-gateway-v1beta1
branch
from
September 7, 2022 08:06
19e1de5
to
1458bf5
Compare
pmalek
force-pushed
the
replace-gateway-v1alpha2-with-gateway-v1beta1
branch
from
September 7, 2022 08:35
1458bf5
to
faa940f
Compare
pmalek
force-pushed
the
replace-gateway-v1alpha2-with-gateway-v1beta1
branch
from
September 7, 2022 09:49
65b32e0
to
9568556
Compare
shaneutt
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR bump Gateway API Gateway resource from
v1alpha2
tov1beta1
.Which issue this PR fixes:
Fixes #2899
Partially addresses #2887
Special notes for your reviewer:
This PR additionally introduces some type aliases in
internal/controllers/gateway/types.go
.I was thinking to put that somewhere else where it could be reused by tests as well (at this moment it cannot due to it being in
internal/
package next to test package) but I left it as is in current state.I'm open for feedback w.r.t
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR