Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Gateway API's Gateway from v1alpha2 to v1beta1 #2900

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Sep 6, 2022

What this PR does / why we need it:

This PR bump Gateway API Gateway resource from v1alpha2 to v1beta1.

Which issue this PR fixes:

Fixes #2899
Partially addresses #2887

Special notes for your reviewer:

This PR additionally introduces some type aliases in internal/controllers/gateway/types.go.

I was thinking to put that somewhere else where it could be reused by tests as well (at this moment it cannot due to it being in internal/ package next to test package) but I left it as is in current state.

I'm open for feedback w.r.t

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Sep 6, 2022
@pmalek pmalek added this to the KIC v2.6.0 milestone Sep 6, 2022
@pmalek pmalek self-assigned this Sep 6, 2022
@pmalek pmalek force-pushed the replace-gateway-v1alpha2-with-gateway-v1beta1 branch from 3119bf4 to aa2ad2a Compare September 6, 2022 15:11
@pmalek pmalek force-pushed the replace-gateway-v1alpha2-with-gateway-v1beta1 branch from aa2ad2a to 2685449 Compare September 6, 2022 15:13
@pmalek pmalek force-pushed the replace-gateway-v1alpha2-with-gateway-v1beta1 branch from 2685449 to 49f1345 Compare September 6, 2022 16:13
@pmalek pmalek marked this pull request as ready for review September 6, 2022 18:10
@pmalek pmalek requested a review from a team as a code owner September 6, 2022 18:10
@pmalek pmalek force-pushed the replace-gateway-v1alpha2-with-gateway-v1beta1 branch from 49f1345 to 55700af Compare September 6, 2022 18:10
shaneutt
shaneutt previously approved these changes Sep 6, 2022
@shaneutt
Copy link
Contributor

shaneutt commented Sep 6, 2022

From CI:

2022-09-06T18:17:23.3976511Z         	            	Internal error occurred: failed calling webhook "validations.kong.konghq.com": failed to call webhook: an error on the server ("unknown resource type to validate: gateway.networking.k8s.io/v1alpha2 gateways") has prevented the request from succeeding

@shaneutt
Copy link
Contributor

shaneutt commented Sep 6, 2022

Would seem we need another update to lock the k8s version in our CI:

failed to deploy addon metallb: resource mapping not found for name: "controller" namespace: "" from "https://raw.githubusercontent.com/metallb/metallb/v0.12.1/manifests/metallb.yaml": no matches for kind "PodSecurityPolicy" in version "policy/v1beta1"

@pmalek pmalek force-pushed the replace-gateway-v1alpha2-with-gateway-v1beta1 branch from 19e1de5 to 1458bf5 Compare September 7, 2022 08:06
@pmalek pmalek force-pushed the replace-gateway-v1alpha2-with-gateway-v1beta1 branch from 1458bf5 to faa940f Compare September 7, 2022 08:35
@pmalek pmalek temporarily deployed to Configure ci September 7, 2022 08:35 Inactive
@pmalek pmalek enabled auto-merge (squash) September 7, 2022 08:38
@pmalek pmalek temporarily deployed to Configure ci September 7, 2022 09:03 Inactive
@pmalek pmalek temporarily deployed to Configure ci September 7, 2022 09:37 Inactive
@pmalek pmalek force-pushed the replace-gateway-v1alpha2-with-gateway-v1beta1 branch from 65b32e0 to 9568556 Compare September 7, 2022 09:49
@pmalek pmalek temporarily deployed to Configure ci September 7, 2022 09:49 Inactive
@pmalek pmalek temporarily deployed to Configure ci September 7, 2022 10:11 Inactive
@pmalek pmalek merged commit 2ef1a64 into main Sep 7, 2022
@pmalek pmalek deleted the replace-gateway-v1alpha2-with-gateway-v1beta1 branch September 7, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove v1alpha2.Gateway support, switch to v1beta1
2 participants