chore: bump Gateway API's HTTPRoute from v1alpha2 to v1beta1 #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
added
the
area/gateway-api
pmalek
force-pushed
the
replace-httproute-v1alpha2-with-httproute-v1beta1
branch
from
daab595
to
154bd81
Compare
pmalek
force-pushed
the
replace-httproute-v1alpha2-with-httproute-v1beta1
branch
from
154bd81
to
8d4e24b
Compare
randmonkey
requested changes
Sep 6, 2022
pmalek
force-pushed
the
replace-httproute-v1alpha2-with-httproute-v1beta1
branch
from
8d4e24b
to
de2f2c7
Compare
pmalek
force-pushed
the
replace-httproute-v1alpha2-with-httproute-v1beta1
branch
from
de2f2c7
to
ed7317c
Compare
randmonkey
approved these changes
Sep 6, 2022
jrsmroz
approved these changes
Sep 6, 2022
randmonkey
deleted the
replace-httproute-v1alpha2-with-httproute-v1beta1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR bumps Gateway API's HTTPRoute from
v1alpha2tov1beta1.Which issue this PR fixes:
Fixes #2895
Partially addresses #2887
Special notes for your reviewer:
I don't really like that this grew in size so much but there's so much code around the specific types for all the fields e.g.
gatewayv1alpha2.Group,gatewayv1alpha2.Kindorgatewayv1alpha2.Namespacethat it's hard to not incur the damage that can be seen in this PR.Ideally we would introduce some type aliases at some point ( in retrospect I might do so in the subsequent PRs for this set of issues).
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR