Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy) rework serviceaccount token #2620

Merged
merged 1 commit into from
Jun 28, 2022
Merged

fix(deploy) rework serviceaccount token #2620

merged 1 commit into from
Jun 28, 2022

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jun 28, 2022

What this PR does / why we need it:
Followup to #2612, see rationale in Kong/charts#621

E2E: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/2579532384

Replace the downward API mount by just using the namespace populated
automatically in the ServiceAccount token. This allows Kuma to detect
the correct token.
@rainest rainest requested a review from a team as a code owner June 28, 2022 22:34
@rainest rainest temporarily deployed to Configure ci June 28, 2022 22:34 Inactive
@rainest rainest enabled auto-merge (rebase) June 28, 2022 22:34
@rainest rainest temporarily deployed to Configure ci June 28, 2022 22:34 Inactive
@rainest rainest temporarily deployed to Configure ci June 28, 2022 22:34 Inactive
@rainest rainest merged commit ff5667f into main Jun 28, 2022
@rainest rainest deleted the fix/yet-more-token branch June 28, 2022 23:31
@shaneutt
Copy link
Contributor

This go merged through a failure of the feature gates integration tests:

https://github.com/Kong/kubernetes-ingress-controller/runs/7102294420?check_suite_focus=true

=== RUN   TestValidationWebhook/a_consumer_with_an_invalid_credential_type_should_fail_validation
time="2022-06-28T22:48:52Z" level=error msg="failed to run validation" component=admission-server error="Secret \"junklawnmowercreds\" not found"
    webhook_test.go:499: 
        	Error Trace:	webhook_test.go:499
        	Error:      	Should be true
        	Test:       	TestValidationWebhook/a_consumer_with_an_invalid_credential_type_should_fail_validation
        	Messages:   	got error string "Internal error occurred: failed calling webhook \"validations.kong.konghq.com\": failed to call webhook: an error on the server (\"Secret \\\"junklawnmowercreds\\\" not found\") has prevented the request from succeeding", want a superstring of "invalid credential type"

I've updated the repository settings so this check is required going forward.

the same test then passed on main so perhaps this was a flake? https://github.com/Kong/kubernetes-ingress-controller/runs/7102887332?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants