Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway Routes with conflicting Services in their backend should not break config build #2565

Closed
2 tasks
rainest opened this issue Jun 10, 2022 · 1 comment · Fixed by #2988
Closed
2 tasks
Assignees
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API bug Something isn't working size/medium
Milestone

Comments

@rainest
Copy link
Contributor

rainest commented Jun 10, 2022

If service population fails due to a single Gateway Route using multiple Services whose annotation sets differ, that failure bubbles up to the parser build and indicates that it failed completely, and the parser build bubbles that up saying that it also failed completely. This blocks the entire config build because of one misconfigured Route.

We should be able to only break the Route in question and skip it, proceeding with the rest of the config. Roughly, this would require logging the failure, adding some entry to ingressRules.ServiceNameToServices that we can recognize as a failure, and then later skipping/logging the route using that service (or the service, forget offhand which we have at the top of the Kong config tree) when building the larger config.

Acceptance:

  • Configuring an xRoute with multiple incompatible Services (e.g. different konghq.com/path annotations) prevents creation of a Kong route for that resource, but does not prevent the parser from building: changes to other routes still take effect.
  • Incompatible Services result in a log indicating that they're not being successfully processed. Optionally combine with Provide parent name to parser service builder #2566 to make this report the affected xRoute.
@scseanchow
Copy link
Contributor

Moving to Milestone 4 as this is a fairly evident nice to have.

@rainest rainest removed their assignment Aug 30, 2022
@mlavacca mlavacca self-assigned this Sep 26, 2022
@pmalek pmalek modified the milestones: KIC v2.7.0, KIC v2.8.0 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API bug Something isn't working size/medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants