fix(sendconfig) suppress deck diff logs at info #2422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Disable deck's full diff output at log level info and above. diffs will only print at debug or trace.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #2411Special notes for your reviewer:
deck doesn't run this output through the regular logging pipeline, so it has no log level, and is controlled independently by the
--silence-events
flag.I opted to limit it to debug and lower since AFAIK it doesn't have any type-specific logic for anything other than Konnect Documents, so it prints changes to certificates and credentials and such, which we don't want at info.
Ideally deck would return diff text to a callers to allow them to determine how to print it (so we could pass it through our logger while the deck CLI does what it does currently), but as it's a direct call to console print from the diff loop, we can only suppress these logs, not add proper level/timestamp/fields formatting (multi-line output makes that a pain even if we could).
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR