perf(request-debugging): improve performance #11722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
reviewed
Oct 11, 2023
| @@ -58,6 +58,9 @@ log_format kong_log_format '$remote_addr - $remote_user [$time_local] ' | |||
|
|
|||
| # Load variable indexes | |||
| lua_kong_load_var_index default; | |||
| lua_kong_load_var_index $http_x_kong_request_debug; | |||
There was a problem hiding this comment.
If we do need these variables we could index them in lua-kong-module by default in the future.
ADD-SP
force-pushed
the
add_sp/perf-req-dbg
branch
from
4871d94
to
8947523
Compare
chobits
reviewed
Oct 12, 2023
ADD-SP
force-pushed
the
add_sp/perf-req-dbg
branch
from
8947523
to
003ef08
Compare
chobits
approved these changes
Oct 12, 2023
windmgc
approved these changes
Oct 12, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please SQUASH AND MERGE
Summary
Improve the performance of the request debugging feature.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
ngx.ctxreq_dyn_hook.runhooks().Issue reference
KAG-2738