-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(integration): avoid passive health check flakiness #10881
Conversation
60fd3b1
to
7d91877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
And I strongly agree with this statement:
using some tolerance on the number of requests answered by each proxied test server, we are testing the health check here, not the ring balancer behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7d91877
to
2c56ee9
Compare
@locao Any benefit to cherrypick/backport this change? |
@RobSerafini yes, this flakiness was in the code since a long time. I will backport this change. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-10881-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ceaddbde341e08fb7650d45c8e7f3e301f5dfae
# Push it to GitHub
git push --set-upstream origin backport-10881-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.2.x release/3.2.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.2.x
# Create a new branch
git switch --create backport-10881-to-release/3.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ceaddbde341e08fb7650d45c8e7f3e301f5dfae
# Push it to GitHub
git push --set-upstream origin backport-10881-to-release/3.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.2.x Then, create a pull request where the |
* style(spec): code formatting change * tests(integration): avoid health check flakiness * tests(integration): more health check flakiness fixes * tests(integration): fix health check flakiness in stream test (cherry picked from commit 9ceaddb)
* style(spec): code formatting change * tests(integration): avoid health check flakiness * tests(integration): more health check flakiness fixes * tests(integration): fix health check flakiness in stream test (cherry picked from commit 9ceaddb)
* style(spec): code formatting change * tests(integration): avoid health check flakiness * tests(integration): more health check flakiness fixes * tests(integration): fix health check flakiness in stream test (cherry picked from commit 9ceaddb)
* style(spec): code formatting change * tests(integration): avoid health check flakiness * tests(integration): more health check flakiness fixes * tests(integration): fix health check flakiness in stream test (cherry picked from commit 9ceaddb)
* style(spec): code formatting change * tests(integration): avoid health check flakiness * tests(integration): more health check flakiness fixes * tests(integration): fix health check flakiness in stream test (cherry picked from commit 9ceaddb)
* style(spec): code formatting change * tests(integration): avoid health check flakiness * tests(integration): more health check flakiness fixes * tests(integration): fix health check flakiness in stream test (cherry picked from commit 9ceaddb)
Summary
Checklist
Full changelog