Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(integration): avoid passive health check flakiness #10881

Merged
merged 4 commits into from
May 19, 2023

Conversation

locao
Copy link
Contributor

@locao locao commented May 16, 2023

Summary

Checklist

Full changelog

  • wait until http test server is unhealthy before continuing the test.
  • using some tolerance on the number of requests answered by each proxied test server, we are testing the health check here, not the ring balancer behavior.
  • removed some parenthesis from comments to avoid messing up with vim.

@locao locao marked this pull request as ready for review May 16, 2023 20:21
@locao locao force-pushed the tests/flaky_passive_hc branch 4 times, most recently from 60fd3b1 to 7d91877 Compare May 17, 2023 16:42
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

And I strongly agree with this statement:

using some tolerance on the number of requests answered by each proxied test server, we are testing the health check here, not the ring balancer behavior.

Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@locao locao merged commit 9ceaddb into master May 19, 2023
@locao locao deleted the tests/flaky_passive_hc branch May 19, 2023 12:42
@RobSerafini
Copy link
Contributor

@locao Any benefit to cherrypick/backport this change?

@locao
Copy link
Contributor Author

locao commented Jun 5, 2023

@RobSerafini yes, this flakiness was in the code since a long time. I will backport this change.

@team-gateway-bot
Copy link
Collaborator

The backport to release/3.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-10881-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ceaddbde341e08fb7650d45c8e7f3e301f5dfae
# Push it to GitHub
git push --set-upstream origin backport-10881-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.x

Then, create a pull request where the base branch is release/3.1.x and the compare/head branch is backport-10881-to-release/3.1.x.

@team-gateway-bot
Copy link
Collaborator

The backport to release/3.2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.2.x release/3.2.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.2.x
# Create a new branch
git switch --create backport-10881-to-release/3.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ceaddbde341e08fb7650d45c8e7f3e301f5dfae
# Push it to GitHub
git push --set-upstream origin backport-10881-to-release/3.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.2.x

Then, create a pull request where the base branch is release/3.2.x and the compare/head branch is backport-10881-to-release/3.2.x.

team-gateway-bot pushed a commit that referenced this pull request Jun 5, 2023
* style(spec): code formatting change

* tests(integration): avoid health check flakiness

* tests(integration): more health check flakiness fixes

* tests(integration): fix health check flakiness in stream test

(cherry picked from commit 9ceaddb)
locao added a commit that referenced this pull request Jun 5, 2023
* style(spec): code formatting change

* tests(integration): avoid health check flakiness

* tests(integration): more health check flakiness fixes

* tests(integration): fix health check flakiness in stream test

(cherry picked from commit 9ceaddb)
locao added a commit that referenced this pull request Jun 5, 2023
* style(spec): code formatting change

* tests(integration): avoid health check flakiness

* tests(integration): more health check flakiness fixes

* tests(integration): fix health check flakiness in stream test

(cherry picked from commit 9ceaddb)
locao added a commit that referenced this pull request Jun 5, 2023
* style(spec): code formatting change

* tests(integration): avoid health check flakiness

* tests(integration): more health check flakiness fixes

* tests(integration): fix health check flakiness in stream test

(cherry picked from commit 9ceaddb)
windmgc pushed a commit that referenced this pull request Jun 6, 2023
* style(spec): code formatting change

* tests(integration): avoid health check flakiness

* tests(integration): more health check flakiness fixes

* tests(integration): fix health check flakiness in stream test

(cherry picked from commit 9ceaddb)
windmgc pushed a commit that referenced this pull request Jun 6, 2023
* style(spec): code formatting change

* tests(integration): avoid health check flakiness

* tests(integration): more health check flakiness fixes

* tests(integration): fix health check flakiness in stream test

(cherry picked from commit 9ceaddb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants