Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape path when using bedrock inference profiles #14310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muscionig
Copy link

Summary

This PR attempts to fix issue #14309 by properly handling URL encoding in AWS SigV4 authentication. Specifically:

  • Escapes the path before setting the request.
  • Unescapes the path when computing the SigV4 signature.

I still need to test this end-to-end with an AWS Bedrock inference profile.

Please let me know if this approach is acceptable. If not, feel free to close this PR.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #14309

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025

CLA assistant check
All committers have signed the CLA.

@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Feb 25, 2025
@team-eng-enablement team-eng-enablement added author/community PRs from the open-source community (not Kong Inc) and removed author/community PRs from the open-source community (not Kong Inc) labels Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ai-proxy does not correctly escape AWS Bedrock inference profile ARN in signature and request
3 participants