feat(jwt-plugin): Add support for EdDSA #12726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27ascii
commented
Mar 12, 2024
| @@ -55,6 +56,7 @@ return { | |||
| "^PS256$", | |||
| "^PS384$", | |||
| "^PS512$", | |||
| "^EdDSA$", | |||
There was a problem hiding this comment.
This is not directly related to the EdDSA support, however I wonder why the pkey checks are not applied for ES256, ES384 and ES512.
Wouldn't it make sense to apply this check for all algorithms and exclude the symmetric ones?
if_match = {
not_match = "^HS",
},
There was a problem hiding this comment.
right, this list has grown over time and indeed it would make sense to apply pkey checks to all asymmetrical keys. I'll add this to my pile. Thanks for brining that up @27ascii
team-eng-enablement
added
the
author/community
hanshuebner
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thank you for the contribution! The change looks good to me, but I'd like another approval from @jschmid1
jschmid1
approved these changes
Mar 13, 2024
jschmid1
added
the
cherry-pick kong-ee
|
Thank you for your contribution @27ascii |
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds support for the EdDSA JWT verification
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Martin Kölbel martin.koelbel@mercedes-benz.com on behalf of Mercedes-Benz Tech Innovation GmbH, Provider Information