fix(jwt-plugin): Add missing pkey sanity check for ES384 and ES512 #12724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
team-eng-enablement
added
the
author/community
hanshuebner
approved these changes
Mar 12, 2024
jschmid1
approved these changes
Mar 13, 2024
jschmid1
added
the
cherry-pick kong-ee
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The plugin might fail due to invalid public keys. The sanity checks are in place for all algorithms except ES384 and ES512. In addition the usage of pkey:verify function has been harmonized across the different algorithms.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Martin Kölbel martin.koelbel@mercedes-benz.com on behalf of Mercedes-Benz Tech Innovation GmbH, Provider Information