-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pluginserver): ensure a change to plugin config takes effect #12718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression test for this will be enabled on the EE side once this is merged. |
flrgh
approved these changes
Mar 12, 2024
bungle
approved these changes
Mar 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
) (cherry picked from commit 97c2651)
Successfully created backport PR for |
gszr
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Mar 13, 2024
Git push to origin failed for release/3.6.x with exitcode 1 |
Successfully created cherry-pick PR for |
AndyZhang0707
pushed a commit
that referenced
this pull request
Mar 19, 2024
) (cherry picked from commit 97c2651)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/language/go
core/language/js
core/language/python
size/XS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where an external plugin -- Go, JS, or Python -- would fail to apply a config via a PATCH request to the admin API.
Issue reference
KAG-3949