Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pluginserver): ensure a change to plugin config takes effect #12718

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

gszr
Copy link
Member

@gszr gszr commented Mar 8, 2024

Summary

This fixes an issue where an external plugin -- Go, JS, or Python -- would fail to apply a config via a PATCH request to the admin API.

Issue reference

KAG-3949

@gszr
Copy link
Member Author

gszr commented Mar 8, 2024

The regression test for this will be enabled on the EE side once this is merged.

@gszr gszr requested a review from locao March 12, 2024 17:41
@bungle bungle merged commit 97c2651 into master Mar 13, 2024
37 checks passed
@bungle bungle deleted the fix/external-plugin-patch branch March 13, 2024 14:15
github-actions bot pushed a commit that referenced this pull request Mar 13, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.6.x:

@gszr gszr added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 13, 2024
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.6.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

AndyZhang0707 pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants