Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router/atc): reset rebuilding flag if route has no id #12654

Merged
merged 3 commits into from
Mar 14, 2024
Merged

fix(router/atc): reset rebuilding flag if route has no id #12654

merged 3 commits into from
Mar 14, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Feb 28, 2024 •
edited
Loading

Summary

The variable rebuilding is a flag to prevent duplicate router building action,
if any error occurs it should be set to false,
or else the router will never be rebuilt again.

KAG-3857

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@chronolaw chronolaw force-pushed the fix/fix_potential_router_build_blocking branch from a842a46 to d50fd88 Compare February 28, 2024 01:46
@chronolaw chronolaw added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Feb 28, 2024
@chronolaw chronolaw force-pushed the fix/fix_potential_router_build_blocking branch from 3fd9b43 to ea26671 Compare March 1, 2024 05:53
@ADD-SP ADD-SP force-pushed the fix/fix_potential_router_build_blocking branch from ea26671 to ce88a85 Compare March 5, 2024 07:09
@ADD-SP ADD-SP merged commit 35c292c into master Mar 14, 2024
26 checks passed
@ADD-SP ADD-SP deleted the fix/fix_potential_router_build_blocking branch March 14, 2024 02:24
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/router size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @Water-Melon @ADD-SP