Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Pongo images instead of rebuilding them #220

Open
Tieske opened this issue Oct 1, 2021 · 4 comments
Open

Upload Pongo images instead of rebuilding them #220

Tieske opened this issue Oct 1, 2021 · 4 comments
Assignees

Comments

@Tieske
Copy link
Member

Tieske commented Oct 1, 2021

Currently Pongo builds images locally after installation. We can probably reduce test times in CI if we upload the images to a docker repo and just pull them. This will also improve the experience for users behind corporate proxies and curated repositories.

2 issues I can see for now;

  • since they are development images, they'll probably be flagged for security issues, do we want to maintain this? (or don't we care about the red flags?)
  • Pongo itself is not versioned. But the images are somewhat tightly coupled to the Pongo version that build it.
@Tieske Tieske self-assigned this Oct 1, 2021
@kongguogang
Copy link

you can release pongo aligned with Kong Gateway release schedule, so your pongo docker image version is interlinked with Kong version?

@Tieske
Copy link
Member Author

Tieske commented Oct 1, 2021

I was thinking about including the Pongo version that created the image, inside the image. Such that a user can extract it and use it as intended.

@esatterwhite
Copy link

I think it would be more user friendly to let it be a separate image.

@esatterwhite
Copy link

I was thinking about including the Pongo version that created the image, inside the image. Such that a user can extract it and use it as intended.

It would be nice to have an image that was tagged with the highest version of kong that it supported. Right now pongo doesn't have any versioning associated with as far as I can tell. That a little troublesome with the documented installation process of just cloning the repo. I don't have much control over one install to the next.

I could pin git hashes, but that is a bit difficult to maintain and reason about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants