Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add keyboard shortcut to close the Edit Environment modal #6511

Closed
kobenguyent opened this issue Sep 15, 2023 · 1 comment
Labels
C-improvement Category: Improvement / Enhancement S-verified Status: Verified by maintainer

Comments

@kobenguyent
Copy link
Contributor

kobenguyent commented Sep 15, 2023

hi, I'd like to have a shortcut to close the environment modal as I don't need to move my mouse and click the button.

Screenshot 2023-09-15 at 16 42 31

my code could be found here develop...kobenguyent:insomnia:feat-shortcut-close-env-form

I updated the UX a bit, when on Edit mode, press the Esc to exit the edit mode then press the shortcut to save the data, this behavior will be the same like user clicks on the Close button.

@filfreire filfreire added C-improvement Category: Improvement / Enhancement S-verified Status: Verified by maintainer labels Sep 27, 2023
@filfreire filfreire changed the title [feat]: Shortcut to close the Edit Environment modal [Feature Request] Add keyboard shortcut to close the Edit Environment modal Sep 27, 2023
@filfreire
Copy link
Member

Closing, see #6518 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-improvement Category: Improvement / Enhancement S-verified Status: Verified by maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants