Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra whitespace in error message in CertificateService #355

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

szesch
Copy link
Contributor

@szesch szesch commented Jun 30, 2023

No description provided.

@szesch szesch requested a review from a team as a code owner June 30, 2023 19:06
@szesch szesch requested a review from a team June 30, 2023 19:06
@CLAassistant
Copy link

CLAassistant commented Jun 30, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ddb9403) 52.86% compared to head (118a7f7) 52.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   52.86%   52.86%           
=======================================
  Files          69       69           
  Lines        5126     5126           
=======================================
  Hits         2710     2710           
  Misses       1840     1840           
  Partials      576      576           
Flag Coverage Δ
2.1 36.48% <0.00%> (ø)
2.2 48.01% <0.00%> (ø)
2.3 48.73% <0.00%> (ø)
2.4 48.80% <0.00%> (ø)
2.5 48.80% <0.00%> (ø)
2.6 48.80% <0.00%> (ø)
2.7 50.33% <0.00%> (ø)
2.8 50.33% <0.00%> (ø)
3.0 50.78% <0.00%> (ø)
3.1 52.26% <0.00%> (ø)
3.2 52.32% <0.00%> (ø)
3.3 52.32% <0.00%> (ø)
community 38.15% <0.00%> (ø)
enterprise 51.52% <0.00%> (ø)
enterprise-nightly 50.97% <0.00%> (ø)
integration 52.86% <0.00%> (ø)
nightly 37.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/certificate_service.go 55.68% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmalek pmalek merged commit 9132554 into main Jun 30, 2023
45 checks passed
@pmalek pmalek deleted the fix-error-message branch June 30, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants