Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin template: Update and add sample versions file #4783

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Nov 15, 2022

Summary

  • Added list of possible protocols
  • Removed "version" field from template
  • Added sample version.yml file

Reason

Need to update for single-sourced plugins.

Draft for now, in case we resolve the delegate_releases: false release incrementation support.

Testing

Won't show up in netlify build, review file in PR only.
Attempting to skip netlify build, will see if it works. Nope.

@lena-larionova lena-larionova added the review:copyedit Request for writer review. label Nov 15, 2022
@lena-larionova lena-larionova requested a review from a team as a code owner November 15, 2022 22:19
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 7328b2d
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/63753c7025114a0009310ebc
😎 Deploy Preview https://deploy-preview-4783--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lena-larionova lena-larionova marked this pull request as draft November 15, 2022 22:22
@lena-larionova lena-larionova marked this pull request as ready for review November 16, 2022 18:21
@cloudjumpercat cloudjumpercat self-requested a review November 16, 2022 19:23
@cloudjumpercat cloudjumpercat self-assigned this Nov 16, 2022
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments, LGTM!

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
@lena-larionova lena-larionova merged commit b6cc8e7 into main Nov 16, 2022
@lena-larionova lena-larionova deleted the plugin-template branch November 16, 2022 19:52
Guaris added a commit that referenced this pull request Nov 17, 2022
* Fix typo in `config.add.querystring` description (#4765)

* chore(deps): update dependency jest to v29.3.1

* fix(deps): update dependency @segment/analytics-next to v1.46.0

* chore: uses REPO argument in installer.sh script (#4770)

Changes the `REPO_PREFIX` argument to `REPO` following changes to the kuma.io/installer.sh changes made in kumahq/kuma-website#1149.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>

* Fix broken link checker (#4774)

* docs(readme): add submodule update instructions

jekyll expects files in src/.repos/kuma/* which are coming from a submodule.

* kic: add translation failures troubleshooting section (#4779)

* kic: add translation failures troubleshooting

* Update troubleshooting.md

* Fix Vale errors, copyedit

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Add uninstall instructions to Ubuntu (#4781)

* uninstall instructions

* spelling

* formatting

* Apply suggestions from code review

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

* [DOCU-1924] New "Manage decK with Docker" page (#4124)

* Add Docker image page

* Add new page

* Apply suggestions from code review

Co-authored-by: Angel <Guaris@users.noreply.github.com>

* Rename file, move to new nav file, minor copyedits

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Move location in nav

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Fix broken link

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Make link to doc version specific

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Apply feedback, fix blank lines in nav file

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Backport doc to prior releases

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Remove from pre-1.7 nav

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: Angel <Guaris@users.noreply.github.com>
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

* Plugin template: Update and add sample versions file (#4783)

* add sample versions file and update plugin template [skip ci]

* uncomment version to prevent build from failing

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* [DOCU-2517] App Reg Multiple RGs and DCR - GA release (#4748)

* changelog

* feat(dcr): how to request with DCR [tdx-2587] (#4716)

* feat(dcr): how to request with DCR [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* [TDX-2195] Dev portal app reg with multi-runtime group support (#4473)

* feat(runtime-groups): remove section in runtime-groups about dev portal app reg

This information is no longer necessary with the availablity of app registration in any runtime group.

* feat(enable-app-reg): update bullet about runtime group compatibility

* feat(enable-app-reg): add sub-bullets about Gateway versions

* feat(app-reg): add runtime group compatibility info

* refactor(app-reg): remove redundant info

* fix(app-reg): replace Kong Gateway with variable

* feat(app-reg): add clarification about default runtime group

* feat(app-reg): link back to default runtime group info

* feat(app-reg): add section about runtime group differences

* refactor(app-reg): update info about OIDC credential claims

* chore(app-reg): adjust indentation of Note to ensure it renders properly

* fix(app-reg): add article and fix spacing

* feat(app-reg): add alpha badges

* Revert "feat(app-reg): add alpha badges"

This reverts commit 43b0711.

* feat(app-reg): add section with badge about alpha stage

* fix(app-reg): move badge out of heading

* refactor(app-reg): update intro to account for multi-runtime groups

* fix(app-reg): move badge below heading

* fix(app-reg): remove unnecessary link and overused word

* refactor(app-reg): make mode names consistent with other usages

* Update app/konnect/dev-portal/applications/enable-app-reg.md

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Update app/konnect/updates.md

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com>
Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Add a/b test support for the top CTA

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: yalhyane <y.alhyane@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Co-authored-by: Michael Heap <m@michaelheap.com>
Co-authored-by: Joshua Schmid <joshua.schmid@konghq.com>
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com>
Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants