Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dcr): how to request with DCR [tdx-2587] #4716

Merged
merged 4 commits into from
Nov 9, 2022
Merged

feat(dcr): how to request with DCR [tdx-2587] #4716

merged 4 commits into from
Nov 9, 2022

Conversation

tomaszwylezek
Copy link
Contributor

@tomaszwylezek tomaszwylezek commented Nov 4, 2022 •
edited
Loading

Signed-off-by: Tomasz Wylężek tomwylezek@gmail.com

Summary

It will add section into DCR part of docs how to properly attach client_id and client_secret within request to runtime instance

Reason

We need to explain how to properly attach client_id and client_secret to request to make people aware of that
https://konghq.atlassian.net/browse/TDX-2587

Testing

https://deploy-preview-4716--kongdocs.netlify.app/konnect/dev-portal/applications/dynamic-client-registration/okta/#how-to-make-successful-request

@tomaszwylezek tomaszwylezek self-assigned this Nov 4, 2022
@tomaszwylezek tomaszwylezek requested a review from a team as a code owner November 4, 2022 09:01
@netlify
Copy link

netlify bot commented Nov 4, 2022 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 5cf8f97
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/636b63a9cf41d100089ada1f
😎 Deploy Preview https://deploy-preview-4716--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tomaszwylezek tomaszwylezek added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Nov 4, 2022
cloudjumpercat
cloudjumpercat requested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggested changes. Thanks for submitting this PR!

@tomaszwylezek
Copy link
Contributor Author

@cloudjumpercat I think that I covered all of the requests, thanks for reviewing! 🎉

@cloudjumpercat cloudjumpercat added the do not merge Issues/ PRs whose changes should not be merged at this time label Nov 8, 2022
@tomaszwylezek
feat(dcr): how to request with DCR [tdx-2587]
abb8f62 
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
@tomaszwylezek
feat(dcr): change wording [tdx-2587]
a22f653 
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
@tomaszwylezek
feat(dcr): change wording [tdx-2587]
af6e858 
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
@tomaszwylezek
feat(dcr): change wording [tdx-2587]
5cf8f97 
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
@tomaszwylezek tomaszwylezek force-pushed the feat/tdx-2587-dcr-request branch from 9692ffb to 5cf8f97 Compare November 9, 2022 08:24
@tomaszwylezek
Copy link
Contributor Author

@cloudjumpercat I noticed you added do not merge label - what's the reason for that? It was because of merge conflicts?

@cloudjumpercat
Copy link
Contributor

@cloudjumpercat I noticed you added do not merge label - what's the reason for that? It was because of merge conflicts?

It's just because we want to wait until the feature is released to GA before publishing the docs. I'll remove the label once the feature has been released.

@Guaris Guaris mentioned this pull request Nov 9, 2022
Merged
@Guaris Guaris changed the base branch from main to release/multiple-rgs November 9, 2022 17:48
@Guaris
Copy link
Contributor

Guaris commented Nov 9, 2022

I'm merging this into a release branch so that when this product goes GA we can merge the associated docs and changelogs in one go according to this https://konghq.atlassian.net/browse/DOCU-2517

@Guaris Guaris removed the do not merge Issues/ PRs whose changes should not be merged at this time label Nov 9, 2022
@Guaris Guaris merged commit d2da067 into Kong:release/multiple-rgs Nov 9, 2022
sunnytoolsmiths pushed a commit that referenced this pull request Nov 16, 2022
@Guaris @tomaszwylezek
@Mierenga @andrewwylde @cloudjumpercat
[DOCU-2517] App Reg Multiple RGs and DCR - GA release (#4748)
b3cf60a 
* changelog

* feat(dcr): how to request with DCR [tdx-2587] (#4716)

* feat(dcr): how to request with DCR [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* [TDX-2195] Dev portal app reg with multi-runtime group support (#4473)

* feat(runtime-groups): remove section in runtime-groups about dev portal app reg

This information is no longer necessary with the availablity of app registration in any runtime group.

* feat(enable-app-reg): update bullet about runtime group compatibility

* feat(enable-app-reg): add sub-bullets about Gateway versions

* feat(app-reg): add runtime group compatibility info

* refactor(app-reg): remove redundant info

* fix(app-reg): replace Kong Gateway with variable

* feat(app-reg): add clarification about default runtime group

* feat(app-reg): link back to default runtime group info

* feat(app-reg): add section about runtime group differences

* refactor(app-reg): update info about OIDC credential claims

* chore(app-reg): adjust indentation of Note to ensure it renders properly

* fix(app-reg): add article and fix spacing

* feat(app-reg): add alpha badges

* Revert "feat(app-reg): add alpha badges"

This reverts commit 43b0711.

* feat(app-reg): add section with badge about alpha stage

* fix(app-reg): move badge out of heading

* refactor(app-reg): update intro to account for multi-runtime groups

* fix(app-reg): move badge below heading

* fix(app-reg): remove unnecessary link and overused word

* refactor(app-reg): make mode names consistent with other usages

* Update app/konnect/dev-portal/applications/enable-app-reg.md

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Update app/konnect/updates.md

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com>
Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Guaris added a commit that referenced this pull request Nov 17, 2022
@Guaris @yalhyane
@renovate @mheap @jschmid1 @czeslavo @cloudjumpercat @lena-larionova @tomaszwylezek @Mierenga @andrewwylde
Merge branch 'main' into konnect (#4792)
53ca272 
* Fix typo in `config.add.querystring` description (#4765)

* chore(deps): update dependency jest to v29.3.1

* fix(deps): update dependency @segment/analytics-next to v1.46.0

* chore: uses REPO argument in installer.sh script (#4770)

Changes the `REPO_PREFIX` argument to `REPO` following changes to the kuma.io/installer.sh changes made in kumahq/kuma-website#1149.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>

* Fix broken link checker (#4774)

* docs(readme): add submodule update instructions

jekyll expects files in src/.repos/kuma/* which are coming from a submodule.

* kic: add translation failures troubleshooting section (#4779)

* kic: add translation failures troubleshooting

* Update troubleshooting.md

* Fix Vale errors, copyedit

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Add uninstall instructions to Ubuntu (#4781)

* uninstall instructions

* spelling

* formatting

* Apply suggestions from code review

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

* [DOCU-1924] New "Manage decK with Docker" page (#4124)

* Add Docker image page

* Add new page

* Apply suggestions from code review

Co-authored-by: Angel <Guaris@users.noreply.github.com>

* Rename file, move to new nav file, minor copyedits

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Move location in nav

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Fix broken link

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Make link to doc version specific

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Apply feedback, fix blank lines in nav file

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Backport doc to prior releases

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Remove from pre-1.7 nav

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: Angel <Guaris@users.noreply.github.com>
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

* Plugin template: Update and add sample versions file (#4783)

* add sample versions file and update plugin template [skip ci]

* uncomment version to prevent build from failing

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* [DOCU-2517] App Reg Multiple RGs and DCR - GA release (#4748)

* changelog

* feat(dcr): how to request with DCR [tdx-2587] (#4716)

* feat(dcr): how to request with DCR [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* [TDX-2195] Dev portal app reg with multi-runtime group support (#4473)

* feat(runtime-groups): remove section in runtime-groups about dev portal app reg

This information is no longer necessary with the availablity of app registration in any runtime group.

* feat(enable-app-reg): update bullet about runtime group compatibility

* feat(enable-app-reg): add sub-bullets about Gateway versions

* feat(app-reg): add runtime group compatibility info

* refactor(app-reg): remove redundant info

* fix(app-reg): replace Kong Gateway with variable

* feat(app-reg): add clarification about default runtime group

* feat(app-reg): link back to default runtime group info

* feat(app-reg): add section about runtime group differences

* refactor(app-reg): update info about OIDC credential claims

* chore(app-reg): adjust indentation of Note to ensure it renders properly

* fix(app-reg): add article and fix spacing

* feat(app-reg): add alpha badges

* Revert "feat(app-reg): add alpha badges"

This reverts commit 43b0711.

* feat(app-reg): add section with badge about alpha stage

* fix(app-reg): move badge out of heading

* refactor(app-reg): update intro to account for multi-runtime groups

* fix(app-reg): move badge below heading

* fix(app-reg): remove unnecessary link and overused word

* refactor(app-reg): make mode names consistent with other usages

* Update app/konnect/dev-portal/applications/enable-app-reg.md

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Update app/konnect/updates.md

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com>
Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Add a/b test support for the top CTA

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: yalhyane <y.alhyane@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Co-authored-by: Michael Heap <m@michaelheap.com>
Co-authored-by: Joshua Schmid <joshua.schmid@konghq.com>
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com>
Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudjumpercat cloudjumpercat cloudjumpercat approved these changes

Assignees

@tomaszwylezek tomaszwylezek

Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomaszwylezek @cloudjumpercat @Guaris