Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TDX-2195] Dev portal app reg with multi-runtime group support #4473

Merged
merged 21 commits into from
Nov 9, 2022

Conversation

Mierenga
Copy link
Contributor

@Mierenga Mierenga commented Sep 16, 2022

Summary

This describes an update to dev portal's app registration. It was previously available only in the default runtime group. App registration is now available as a Tech Preview in all runtime groups. However, for compatibility with Kong Gateway's < 3.0, there are some differences with how it is applied, depending on the runtime group.

Reason

https://konghq.atlassian.net/browse/TDX-2195
Application registration is opening support for any runtime group. Only compatible with Kong Gateway versions >= 3.0

Testing

@Mierenga Mierenga added do not merge Issues/ PRs whose changes should not be merged at this time pr/wip labels Sep 16, 2022
@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 39e2632
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/636aca58981f2800086eec06
😎 Deploy Preview https://deploy-preview-4473--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@acgoldsmith acgoldsmith modified the milestones: Konnect-2209, summit Sep 20, 2022
@cloudjumpercat
Copy link
Contributor

@Mierenga Will you be adding additional changes or is this ready for a copy edit? Thanks!

@Mierenga
Copy link
Contributor Author

@cloudjumpercat There will be additional changes in the next couple weeks before it is ready for docs review, thanks for checking in!

@cloudjumpercat
Copy link
Contributor

@Mierenga Hi! Just checking in to see if you have any more changes for this PR. Thanks!

@lena-larionova lena-larionova removed this from the summit milestone Nov 1, 2022
@Mierenga Mierenga force-pushed the feat/konnect-portal-app-reg-multi-rg branch from e4b2b1b to d4bf76b Compare November 7, 2022 23:22
@Mierenga Mierenga marked this pull request as ready for review November 7, 2022 23:26
@Mierenga Mierenga requested a review from a team as a code owner November 7, 2022 23:26
@Mierenga
Copy link
Contributor Author

Mierenga commented Nov 7, 2022

@cloudjumpercat This info is ready for review from the docs team, thanks!

@Mierenga Mierenga added review:copyedit Request for writer review. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? and removed do not merge Issues/ PRs whose changes should not be merged at this time pr/wip review:copyedit Request for writer review. labels Nov 7, 2022
@Guaris Guaris self-assigned this Nov 8, 2022
@Mierenga Mierenga requested a review from Guaris November 8, 2022 19:57
@nateslo nateslo self-requested a review November 8, 2022 20:09
Copy link
Member

@nateslo nateslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from a technical standpoint

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Copy link
Contributor

@andrewwylde andrewwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Guaris Guaris changed the base branch from main to release/multiple-rgs November 9, 2022 16:01
@Guaris
Copy link
Contributor

Guaris commented Nov 9, 2022

I'm pushing this to a feature branch with this PR
#4716

So they can both go out together on Monday

@Guaris Guaris merged commit 97c8534 into release/multiple-rgs Nov 9, 2022
@Guaris Guaris deleted the feat/konnect-portal-app-reg-multi-rg branch November 9, 2022 18:01
sunnytoolsmiths pushed a commit that referenced this pull request Nov 16, 2022
* changelog

* feat(dcr): how to request with DCR [tdx-2587] (#4716)

* feat(dcr): how to request with DCR [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* [TDX-2195] Dev portal app reg with multi-runtime group support (#4473)

* feat(runtime-groups): remove section in runtime-groups about dev portal app reg

This information is no longer necessary with the availablity of app registration in any runtime group.

* feat(enable-app-reg): update bullet about runtime group compatibility

* feat(enable-app-reg): add sub-bullets about Gateway versions

* feat(app-reg): add runtime group compatibility info

* refactor(app-reg): remove redundant info

* fix(app-reg): replace Kong Gateway with variable

* feat(app-reg): add clarification about default runtime group

* feat(app-reg): link back to default runtime group info

* feat(app-reg): add section about runtime group differences

* refactor(app-reg): update info about OIDC credential claims

* chore(app-reg): adjust indentation of Note to ensure it renders properly

* fix(app-reg): add article and fix spacing

* feat(app-reg): add alpha badges

* Revert "feat(app-reg): add alpha badges"

This reverts commit 43b0711.

* feat(app-reg): add section with badge about alpha stage

* fix(app-reg): move badge out of heading

* refactor(app-reg): update intro to account for multi-runtime groups

* fix(app-reg): move badge below heading

* fix(app-reg): remove unnecessary link and overused word

* refactor(app-reg): make mode names consistent with other usages

* Update app/konnect/dev-portal/applications/enable-app-reg.md

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Update app/konnect/updates.md

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com>
Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Guaris added a commit that referenced this pull request Nov 17, 2022
* Fix typo in `config.add.querystring` description (#4765)

* chore(deps): update dependency jest to v29.3.1

* fix(deps): update dependency @segment/analytics-next to v1.46.0

* chore: uses REPO argument in installer.sh script (#4770)

Changes the `REPO_PREFIX` argument to `REPO` following changes to the kuma.io/installer.sh changes made in kumahq/kuma-website#1149.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>

* Fix broken link checker (#4774)

* docs(readme): add submodule update instructions

jekyll expects files in src/.repos/kuma/* which are coming from a submodule.

* kic: add translation failures troubleshooting section (#4779)

* kic: add translation failures troubleshooting

* Update troubleshooting.md

* Fix Vale errors, copyedit

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Add uninstall instructions to Ubuntu (#4781)

* uninstall instructions

* spelling

* formatting

* Apply suggestions from code review

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

* [DOCU-1924] New "Manage decK with Docker" page (#4124)

* Add Docker image page

* Add new page

* Apply suggestions from code review

Co-authored-by: Angel <Guaris@users.noreply.github.com>

* Rename file, move to new nav file, minor copyedits

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Move location in nav

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Fix broken link

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Make link to doc version specific

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Apply feedback, fix blank lines in nav file

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Backport doc to prior releases

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Remove from pre-1.7 nav

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: Angel <Guaris@users.noreply.github.com>
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>

* Plugin template: Update and add sample versions file (#4783)

* add sample versions file and update plugin template [skip ci]

* uncomment version to prevent build from failing

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* [DOCU-2517] App Reg Multiple RGs and DCR - GA release (#4748)

* changelog

* feat(dcr): how to request with DCR [tdx-2587] (#4716)

* feat(dcr): how to request with DCR [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* feat(dcr): change wording [tdx-2587]

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>

* [TDX-2195] Dev portal app reg with multi-runtime group support (#4473)

* feat(runtime-groups): remove section in runtime-groups about dev portal app reg

This information is no longer necessary with the availablity of app registration in any runtime group.

* feat(enable-app-reg): update bullet about runtime group compatibility

* feat(enable-app-reg): add sub-bullets about Gateway versions

* feat(app-reg): add runtime group compatibility info

* refactor(app-reg): remove redundant info

* fix(app-reg): replace Kong Gateway with variable

* feat(app-reg): add clarification about default runtime group

* feat(app-reg): link back to default runtime group info

* feat(app-reg): add section about runtime group differences

* refactor(app-reg): update info about OIDC credential claims

* chore(app-reg): adjust indentation of Note to ensure it renders properly

* fix(app-reg): add article and fix spacing

* feat(app-reg): add alpha badges

* Revert "feat(app-reg): add alpha badges"

This reverts commit 43b0711.

* feat(app-reg): add section with badge about alpha stage

* fix(app-reg): move badge out of heading

* refactor(app-reg): update intro to account for multi-runtime groups

* fix(app-reg): move badge below heading

* fix(app-reg): remove unnecessary link and overused word

* refactor(app-reg): make mode names consistent with other usages

* Update app/konnect/dev-portal/applications/enable-app-reg.md

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

Co-authored-by: Andrew Wylde <drewkakes@gmail.com>

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Update app/konnect/updates.md

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com>
Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

* Add a/b test support for the top CTA

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: yalhyane <y.alhyane@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Co-authored-by: Michael Heap <m@michaelheap.com>
Co-authored-by: Joshua Schmid <joshua.schmid@konghq.com>
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com>
Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants