-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deck diff shows different plugin configuration than sync creates #538
Comments
Hi @odsock, thanks for highlighting this! I dug this a bit and apparently this is related to the third-party library
Not only that, the library seems to be pretty much unreliable when dealing with arrays, as changing the content of the initial one affects the final output as well:
There are already some GH issues related to this (yudai/gojsondiff#30 and yudai/gojsondiff#24), but the repo has not been updated in the last 4 years, so maybe we should evaluate something else. |
This looks like a good candidate:
Also this, although it doesn't return the matched lines:
|
@GGabriele Can we try fixing the bug in the third-party library that we are currently using? That path maybe simpler. |
#635 has been merged. Closing this. Please feel free to comment back or open a new issue if something weird pops out! |
Using decK v1.8.2 (b538f70).
When updating a request-transformer plugin configuration to change list of headers to remove, the diff output is incorrect. I'm changing the config from removing one header, to removing two different headers. Syncing the change has the correct result, only the diff output is wrong (output in both diff and sync).
Original state yaml:
The change:
The diff output shows the original single entry being removed, and then the first of the two new entries twice:
It should be this:
Example configuration and output attached.
deck-test.zip
The text was updated successfully, but these errors were encountered: