Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support to specify IDs for entities #29

Closed
hbagdi opened this issue Jun 27, 2019 · 1 comment · Fixed by #86
Closed

feature: add support to specify IDs for entities #29

hbagdi opened this issue Jun 27, 2019 · 1 comment · Fixed by #86
Assignees
Labels
feature New feature or request
Milestone

Comments

@hbagdi
Copy link
Member

hbagdi commented Jun 27, 2019

Currently, IDs cannot be specified in decK for any entitiy, and if they are specified, they are just ignored.
This feature will also benefit Kong's Ingress Controller as the IDs can be deterministic.

@hbagdi
Copy link
Member Author

hbagdi commented Sep 21, 2019

Although, this sounds simple enough, it is much more complicated.

The redesign impacts all areas and will make the codebase uniform, opening up the doors to auto-generating most parts of decK, simplifying maintenance and adding support for further entities and even making decK work for other RESTful APIs.

Here are the broken down tasks (these might not be granular enough):

  • Use ID based foreign references.
  • Update targetstate to match IDs with the current state and perform a diff including the ID. Autogen a UUID when one doesn't exist.
  • The schema is to be generated automatically using the Content struct. Use CI to detect any drift. This also opens up door for feature request: add support for reading JSON files #35
  • JSONschema based input file validation.

@hbagdi hbagdi self-assigned this Oct 6, 2019
@hbagdi hbagdi mentioned this issue Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant