Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fixed 0.0001 min treshold for TakerFee #884

Closed
cipig opened this issue Mar 30, 2021 · 2 comments · Fixed by #1971
Closed

remove fixed 0.0001 min treshold for TakerFee #884

cipig opened this issue Mar 30, 2021 · 2 comments · Fixed by #1971

Comments

@cipig
Copy link
Member

cipig commented Mar 30, 2021

Non-UTXO coins still have a fixed threshold of 0.0001 for TakerFee. That is more than 5$ in BTC: https://bscscan.com/tx/0x2e07a377df3139f60c639e260b34c2dbc21b0e57436f00430991d28bc8184eea
For UTXO coins this was removed/set to dust: #545 (comment), but BEP20 still has it (and i assume ERC20 too). Would be good if that can be removed or lowered.

@artemii235 artemii235 self-assigned this Apr 2, 2021
@artemii235
Copy link
Member

artemii235 commented Apr 2, 2021

Thanks for creating the issue! There is a backward compatibility problem in this change - outdated makers will still use the 0.0001 threshold and reject the takers paying less (also banning them). I will discuss it with the team next week.

@cipig
Copy link
Member Author

cipig commented Apr 2, 2021

maybe it's time for a "hard fork" :-)
but also sounds like another case for #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants