Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up finished swaps subscription topics. #771

Closed
artemii235 opened this issue Dec 13, 2020 · 1 comment
Closed

Clean up finished swaps subscription topics. #771

artemii235 opened this issue Dec 13, 2020 · 1 comment
Labels
bug: P2P bug: security priority: urgent Critical tasks requiring immediate action.

Comments

@artemii235
Copy link
Member

After swap finishes the subscription topic record stays on relay forever which results into minor mem leak.
@artemii235 artemii235 self-assigned this Dec 13, 2020
@artemii235 artemii235 changed the title Cleanup unused swaps subscription topics. Clean up unused swaps subscription topics. Dec 13, 2020
@artemii235 artemii235 changed the title Clean up unused swaps subscription topics. Clean up finished swaps subscription topics. Dec 13, 2020
@onur-ozkan onur-ozkan added improvement: resource usage Improvements made on resource usage on runtime or/and compile time improvement: security Improvements made on runtime security and removed enhancement labels Dec 12, 2024
@onur-ozkan onur-ozkan added the priority: urgent Critical tasks requiring immediate action. label Dec 12, 2024
@onur-ozkan
Copy link
Member

onur-ozkan commented Dec 12, 2024 •
edited
Loading

This should be checked to see whether it is still the case.

Update: This still possible on both unsubscription and disconnection cases.

@onur-ozkan onur-ozkan pinned this issue Dec 12, 2024
@onur-ozkan onur-ozkan mentioned this issue Dec 17, 2024
Merged
@onur-ozkan onur-ozkan added bug: P2P bug: security and removed improvement: resource usage Improvements made on resource usage on runtime or/and compile time improvement: security Improvements made on runtime security improvement: P2P labels Dec 17, 2024
@onur-ozkan onur-ozkan unpinned this issue Dec 18, 2024
@onur-ozkan onur-ozkan mentioned this issue Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: P2P bug: security priority: urgent Critical tasks requiring immediate action.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artemii235 @onur-ozkan