Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicting on mouse alleles fails due to erroneous nomenclature conversion #82

Closed
jonasscheid opened this issue Dec 7, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jonasscheid
Copy link
Collaborator

Predicting 8mers on mouse alleles with syfpeithi, e.g. H2-Kb keeps resulting in

No model found for H-2-Kb with length 8

although the underlying matrix is available.

The issue here is, that self.convert_alleles converts the given H2-Kb to the internal epytope representation K_b. This representation is then used here to load the matrix K_b_8. However it is not found, because the matrix file is called H2_Kb_8.py.

For HLA alleles the conversion is working, so I would propose to change the files and strip H2.
We should also look into how the nomenclature is handled internally in external predictors (netmhc family)

Let's also increment the tests of the epitopeprediction with mouse alleles accordingly.

@jonasscheid jonasscheid added the bug Something isn't working label Dec 7, 2022
@christopher-mohr christopher-mohr self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants