-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve permit join #24257
fix: Improve permit join #24257
Conversation
Merged |
Will have to link the various branches in package.json (or ci?) for all repos to sync up (at least for tests). |
I think it would be the best to publish pre-release packages of the deps. Npm supports installing from Git but it won't contain the compiled TS code. Shall I publish a pre-release version for zh? |
Do we want to implement the remaining TODO in Koenkk/zigbee-herdsman#1214 ? It would be the only change left in ZH I think (need zh+frontend+z2m change). interface PermitJoinChangedPayload {
time: number; // [0-254]
device?: Device; // not used at this time but aligns the API
} And this gets emitted only on open and close, frontend does the ticking logic. For the packages, for CI, I guess you could check out the various branches, compile them, and use these local folders instead of npm. But might be easier to publish pre-releases. |
I'm not sure if we should solve that one, it will also break the HA permit join timeout ( zigbee2mqtt/lib/extension/homeassistant.ts Line 2132 in e06848d
|
e0a033a
to
a919238
Compare
* fix: Improve permit join * Update Home Assistant permit join switch * Remove `permit_join` from `settings.schema.json` * Update zigbee-herdsman version to pre-release. * Fix pnpm overrides * Update test/homeassistant.test.js --------- Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
This reverts commit 2124d34.
permit_join
setting.TODO: