-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce TS strict
type checking.
#23601
Conversation
Note to self: all tests are passing locally in 4c7a5fa (ci fails because of build) |
CI passes now, @Nerivec let me know if this can be merged |
Should be good to go. I think an extra manual check is warranted in z2m, zhc, zh and frontend on the following:
Since a few occurrences changed from |
Great, I will hold it back for a couple of days, need to make a hotfix release. |
Require ZH: Koenkk/zigbee-herdsman#1146
Require ZHC: TODO
@Koenkk I'll let you check the HA extension, don't know much about what it's expecting on the other other side, so, didn't touch it much.
Settings are a bit nasty too. Seems there a need for a
SettingsWithDefaults
type or something similar, to avoid the manyxyz | undefined
that result from current typing?And have to confirm the logic in zigbee.ts for
resolveDevice
andresolveEntity
.