Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert logger into a class. #22129

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Convert logger into a class. #22129

merged 1 commit into from
Apr 7, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Apr 7, 2024

Additional changes:

  • Short-circuit debug calls to winston if log_level isn't debug (improves performance, since all levels are synced across transports it causes no issue).
  • Remove init/logOutput calls from Controller (& tests), no longer needed.
  • Fix up first logged line that displays what logging is active/enabled. Purely cosmetic.

@Koenkk Koenkk merged commit 3c1a4af into Koenkk:dev Apr 7, 2024
8 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Apr 7, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants