Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update "nan" to 2.18.0 to fix building on Node 20+ #19983

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Dec 2, 2023

@Koenkk
Copy link
Owner

Koenkk commented Dec 2, 2023

Could you add this as a dependency in package.json? Otherwise this change might get lost once dependencies are upgraded again.

@jirutka
Copy link
Contributor Author

jirutka commented Dec 2, 2023

How can it be lost when upgrading other dependencies? npm update does not downgrade dependencies.

@Koenkk Koenkk merged commit 9c8aee1 into Koenkk:dev Dec 2, 2023
11 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 2, 2023

Looks to be good indeed, https://github.com/Koenkk/zigbee2mqtt/actions/runs/7072193150 didn't alter it.

@jirutka jirutka deleted the update-nan branch December 3, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants