Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bosch smoke alarm II ssiasZone command #861

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Conversation

vjonas
Copy link
Contributor

@vjonas vjonas commented Jan 8, 2024

I ran into formatting issues. It logs too many changes. Not sure how to align that, how should I do that? @Koenkk
Potentially we could enable some formatter as Prettier to the codebase?
This should allow users to send a mqtt topic to toggle the alarm and intruder state of the smoke detector II.

@Koenkk
Copy link
Owner

Koenkk commented Jan 8, 2024

Could you undo the formatting changes and just add the cluster?

@vjonas
Copy link
Contributor Author

vjonas commented Jan 9, 2024

Could you undo the formatting changes and just add the cluster?

What would be the best way to do that? Using VSCode, I tried auto fix linting

@Koenkk
Copy link
Owner

Koenkk commented Jan 9, 2024

I would revert all changes and add just the lines needed.

@vjonas
Copy link
Contributor Author

vjonas commented Jan 10, 2024

I would revert all changes and add just the lines needed.

Should be good now.

@Koenkk Koenkk marked this pull request as ready for review January 10, 2024 20:10
@Koenkk Koenkk merged commit 48680fa into Koenkk:master Jan 10, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jan 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants