Ember: workaround: auto-register unknown multicasts in coordinator #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, on Monday I will be able to test it if it is available in dev branch. |
|
thanks! |
|
Thanks! Looking forward, having the same issue... |
|
@Nerivec I just tested it and I can confirm that in the dev branch, with this fix, the EGLO 99099 now works also with the ember driver, thanks!
|
|
Great. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically register unknown multicast group IDs in coordinator multicast table to allow devices using this scheme for state updates to work without needing manual code change. Should take care of Koenkk/zigbee2mqtt#22928
@LamerTex I don't have a device that does this, can you confirm this works once this is available in dev branch?
Also a bit of housekeeping, use ZSpec instead of adapter-specific vars.