Added support for namron edge thermostat #8650
Conversation
bskjon
force-pushed
the
namron_edge_thermostat
branch
2 times, most recently
from
1f41119 to
257b0bb
Compare
bskjon
force-pushed
the
namron_edge_thermostat
branch
from
257b0bb to
95eb9b3
Compare
src/devices/namron.ts
Outdated
| const tzNamronOperationMode = fzNamronOperationMode.fromFzToTz(); | ||
|
|
||
| const fzNamronFault = { | ||
| 0: 'No Fault', |
There was a problem hiding this comment.
Please make all these snake_case, also for e.g. fzNamronWorkDays
There was a problem hiding this comment.
also how should i deal with: {0: 'Mon-Fri Sat-Sun', 1: 'Mon-Sat Sun', 2: 'No Time Off', 3: 'Time Off'};
There was a problem hiding this comment.
mon_to_fri_and_sat_sun, mon_to_sat_and_sun, no_time_off, time_off
There was a problem hiding this comment.
There is no way to keep the "-" between?
src/devices/namron.ts
Outdated
| device.powerSource = 'Mains (single phase)'; | ||
| device.save(); | ||
| }, | ||
| extend: [m.electricityMeter({voltage: false}), m.onOff({powerOnBehavior: false})], |
There was a problem hiding this comment.
Can you check whether it is possible to use modern extend for all the other attributes, this should allow to get rid of a lot of code here.
There was a problem hiding this comment.
🙃 unfortuentaly, i dont see any i can use here
There was a problem hiding this comment.
It doesn't have any cluster or attribute that i can see is usable for this device. Most of the common cluster info is already defined in the fz tz thermostat, and not in the modernExtend. Also for some reason, the manufacturer can't decide which attribute ids they want to stick to, so most of the new attribute ids is for this device only it seems.
There was a problem hiding this comment.
That's not a reason modern extend cannot be used, you can take the Lumi modern extends as an example:
zigbee-herdsman-converters/src/lib/lumi.ts
Line 1574 in 400fa2c
There was a problem hiding this comment.
I've got no clue how to test or verify this..
How will i be able to debug or test that this works?
There was a problem hiding this comment.
It shouldn't be much different than how you developed initial support for this device, I recommend to do it via an external converter.
There was a problem hiding this comment.
Is the current code fine, or is there other changes that are required?
bskjon
force-pushed
the
namron_edge_thermostat
branch
from
ce555ca to
c9e2e73
Compare
|
Would it be possible to kindly include the floor temperature sensor's temperature as well, if feasible? |
From what I've seen, there is no other data attribute. So you have to use the one you have selected as main sensor/sensor mode |
|
Getting a lot of these errors in the logs: First occurred: February 9, 2025 at 22:20:52 (6319 occurrences) Invalid option for select.varmekabler_vaskerom_system_mode: 'heat' (valid options: ['0', '1', '3', '4']) |
Mhm, mapped it up in reverse. Should be fixed when an updated z2m drops or so |
Adding support for Namron Edge Thermostat
https://www.elektroimportoren.no/namron-zigbee-edge-termostat-hvit/4512783/Product.html
Addresses issue: #24047 Koenkk/zigbee2mqtt#24047