Fix inverted state on Tuya motorized blinds
#8481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "Invert cover" is enabled, the state published when the covers reach the ends are reversed. This is because the inverted position is used to determine the `state` and is then inverted once more. To resolve this, the `state` is determined using the final position only. The `state` will be published as CLOSE when the position is 0, otherwise OPEN is published. Verified with the A-OK AM25 that is recognized as B09M3R35GC _TZE200_9p5xmj5r Unable to verify with a motor that is non-inverted.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "Invert cover" is enabled, the state published when the covers reach the ends are reversed. This is because the inverted position is used to determine the
stateand is then inverted once more.To resolve this, the
stateis determined using the final position only. Thestatewill be published as CLOSE when the position is 0, otherwise OPEN is published.Verified with the A-OK AM25 that is recognized as B09M3R35GC _TZE200_9p5xmj5r Unable to verify with a motor that is non-inverted.