Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ZBM5 123-channel wall switch. #8314

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Added ZBM5 123-channel wall switch. #8314

merged 4 commits into from
Nov 18, 2024

Conversation

liubotongs
Copy link
Contributor

No description provided.

isModernExtend: true,
};
},
sonoffOnOff(args: {powerOnBehavior?: boolean; skipDuplicateTransaction?: boolean; endpointNames?: string[]}): ModernExtend {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used, please remove it.

description: 'Zigbee Smart two-channel wall switch (type 120).',
exposes: [],
extend: [
deviceEndpoints({endpoints: {first: 1, second: 2}}),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
deviceEndpoints({endpoints: {first: 1, second: 2}}),
deviceEndpoints({endpoints: {l1: 1, l2: 2}}),

description: 'Zigbee Smart three-channel wall switch (type 120).',
exposes: [],
extend: [
deviceEndpoints({endpoints: {first: 1, second: 2, third: 3}}),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
deviceEndpoints({endpoints: {first: 1, second: 2, third: 3}}),
deviceEndpoints({endpoints: {l1: 1, l2: 2, l3: 3}}),

@Koenkk
Copy link
Owner

Koenkk commented Nov 14, 2024

Could you also submit a picture for the docs? This can be done by:

  1. Create a fork by clicking here
  2. Go to the public/images/devices directory, Add file -> Upload files
  3. Upload the files and press Commit changes
  4. Press Contribute -> Open pull request -> update title/description -> Create pull request

Make sure that:

  • The filename is ZBM5-1C-120.png
  • The size is 512x512
  • The background is transparent (use e.g. Adobe remove background)

@liubotongs
Copy link
Contributor Author

Could you also submit a picture for the docs? This can be done by:

1. Create a fork by clicking [here](https://github.com/Koenkk/zigbee2mqtt.io/fork)

2. Go to the `public/images/devices` directory, _Add file_ -> _Upload files_

3. Upload the files and press _Commit changes_

4. Press _Contribute_ -> _Open pull request_ -> update title/description -> _Create pull request_

Make sure that:

* The filename is `ZBM5-1C-120.png`

* The size is 512x512

* The background is transparent (use e.g. [Adobe remove background](https://new.express.adobe.com/tools/remove-background))

Yes, it has been submitted before.

@Koenkk Koenkk merged commit 6113ce2 into Koenkk:master Nov 18, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Nov 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants