lib/tuya: tuyaTz.datapoints wrongly updates { state: } object

[robvanoostenrijk]

After looking more into the behavior reported in Koenkk/zigbee2mqtt#24425, it happens only for Tuya devices and its not an error in Zigbee2MQTT itself.

Problem:

When publishing a set message with multiple properties specified, the tuzaTz.datapoints default converter fails to update the state correctly.

tuyaTz.datapoints loops through the properties in the current message (because ConverterSet is called only once.

However when it builds the state object to return it uses the key parameter of the main call, not the loop variable attr.
This causes the values to be overwritten in the state object under the same key.

For example:

{ "preset": "manual", "system_mode": "cool", "current_heating_setpoint": 27 }

Leads to state:

{ "preset": 27 }

And

{ "current_heating_setpoint": 27, "preset": "manual", "system_mode": "cool"  }

to

{ "current_heating_setpoint": "cool" }

This PR resolves the issue by correctly using the attr loop variable to build the return state.

Note: The device values were set correctly, however the state in Zigbee2MQTT did not reflect the device state due to the wrong return value.

[Koenkk]

Thanks!