Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added current level startup to ikea lights #8049

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

dannyneup
Copy link
Contributor

@dannyneup dannyneup commented Sep 29, 2024

I've added the current level startup to the Ikea lights LED2005R5/LED2106R3 as requested in zigbee2mqtt#22786

It might be worth considering including the attribute in the ikeaLight class, as the poweronbehavior is also set there by default and requires the current level startup or on level anyways. I therefore see no reason to make this attribute directly available to users.
However, I have refrained from doing this for the time being, as I only have this one device type to test and, to be honest, I am not deep enough in the code to be able to make a qualified judgment.
I tested with this external converter. Works without any problems.

const { light } = require('zigbee-herdsman-converters/lib/modernExtend');

const definition = {
    zigbeeModel: ['TRADFRI bulb GU10 WS 345lm'],
    model: 'TRADFRI bulb GU10 WS 345lm',
    vendor: 'IKEA of Sweden',
    description: 'Automatically generated definition',
    extend: [
        light(
            { 
                colorTemp: { "range": [250, 454] }, 
                levelConfig: { 
                    disabledFeatures: [
                        "on_off_transition_time",
                        "on_transition_time", 
                        "off_transition_time",
                        "on_level"
                    ]
                }
            } 
        ) 
    ], 
    meta: {}
};

module.exports = definition;

@Koenkk
Copy link
Owner

Koenkk commented Sep 29, 2024

I think it makes sense to add this to all IKEA bulbs

@dannyneup
Copy link
Contributor Author

I think it makes sense to add this to all IKEA bulbs

Done :)

@marazmarci
Copy link
Contributor

I think it makes sense to add this to all IKEA bulbs

Done :)

@dannyneup, thanks! Could you please also update the PR's title? It would be a bit misleading in the git history if it were merged with this commit message 🙂

@dannyneup dannyneup changed the title added current level startup to ikea LED2005R5/LED2106R3 added current level startup to ikea lights Sep 29, 2024
@Koenkk Koenkk merged commit 3f9376f into Koenkk:master Sep 30, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Sep 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants